Drop support for Go 1.6 and lower #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnehormann
approved these changes
Nov 12, 2017
5 tasks
eldebrim
added a commit
to osuosl-cookbooks/osl-letsencrypt-boulder-server
that referenced
this pull request
Nov 13, 2017
Boulder needs the goose plugin to function, which requires the go-sql-driver, which no longer supports go =< 1.6 [1]. This causes the boulder cookbook to fail. [1] go-sql-driver/mysql#696
eldebrim
added a commit
to osuosl-cookbooks/osl-letsencrypt-boulder-server
that referenced
this pull request
Nov 13, 2017
Boulder needs the goose plugin to function, which requires the go-sql-driver, which no longer supports go =< 1.6 [1]. This causes the boulder cookbook to fail. [1] go-sql-driver/mysql#696
eldebrim
added a commit
to osuosl-cookbooks/osl-letsencrypt-boulder-server
that referenced
this pull request
Nov 13, 2017
Boulder needs the goose plugin to function, which requires the go-sql-driver, which no longer supports go =< 1.6 [1]. This causes the boulder cookbook to fail. [1] go-sql-driver/mysql#696
|
Could you revert this, please, at least until Go 1.6 support is entirely dropped from Google App Engine? 1.8 is the default version now, but users can still opt back in to drop back to 1.6. Once GAE gets to 1.10, versions will be available much faster, and your support plan will be compatible with GAE. |
bLamarche413
pushed a commit
to bLamarche413/mysql
that referenced
this pull request
Mar 23, 2018
* Drop support for Go 1.6 and lower * Remove cloneTLSConfig for legacy Go versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed here, I would like to make it an official guideline, that we aim to support the 3 latest versions of Go (+tip) at any time.